Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for patch method #4637

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Support for patch method #4637

merged 1 commit into from
Sep 10, 2021

Conversation

jprudent
Copy link
Contributor

@jprudent jprudent commented Sep 9, 2021

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

I tried to pass method=patch to the upload component, but it doesn't pass the check. The only supported methods are POST and PUT. This is unnecessary restrictive.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?

User can use RESTful API with the PATCH semantic

  1. What will say in changelog?

Support PATCH method in the upload component

  1. Does this PR contains potential break change or other risk?

Some very old browsers doesn't support the PATCH method at all

Changelog description (Optional if not new feature)

  1. English description

Support PATCH method in the upload component

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🙏

There is nothing HTTP speaking to prevent a multipart request with PATCH semantics.
@tangjinzhou tangjinzhou merged commit 4f36599 into vueComponent:next Sep 10, 2021
@jprudent jprudent deleted the patch-1 branch September 10, 2021 05:18
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants