Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Allow config for multiple variables #508

Closed
Austio opened this issue Feb 10, 2017 · 3 comments
Closed

Feature Request: Allow config for multiple variables #508

Austio opened this issue Feb 10, 2017 · 3 comments

Comments

@Austio
Copy link

Austio commented Feb 10, 2017

Hello, I am wanting to create a PR for a small addition and wanted to make sure that it is something that is needed.

Currently the config/index.js only has a configurable ENV variable. This isn't ideal for running tests while having a dev server running b/c the ports collide.

Proposal: I would like to create a PR to update the cli to generate a config that merges the entire test/dev in config/index.js for the dev key. Also webpack will need to be updated to use the exports correctly.

Please let me know if this is wanted and i'll knock it out.

Thanks!

@LinusBorg
Copy link
Contributor

How would that look from a usage perspective?

I don't see the advantage from how you describe it. Currently, you can add more than one variable to the *.env.js files if you need to. Wouldn't that be enough?

@Austio
Copy link
Author

Austio commented Feb 13, 2017

Benefit would be that you could specify different options that are not in the dev.env property of teh index.js. A good example of things that could change which are not currently updatable are the dev.port or autoOpenBrowser.

If we did this, I would think it would be similar to the current setup only instead of requiring the environment under dev.env we would require it and then merge it on top of the index.js.

So, index.js would then really be more of defaults, and dev/prod/test would be extensions on top of that where you could specify different ports/etc as needed for the different envs.

@LinusBorg
Copy link
Contributor

So this never went on, right? I'm in the last steps of merging #975 which will bring a few new config options for the things you mentioned.

Have a look and open a a new issue if you still think this config can be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants