Skip to content

feat: support AST for template compile #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 8, 2019
Merged

feat: support AST for template compile #68

merged 3 commits into from
Dec 8, 2019

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Jul 31, 2019

/ping @znck @sodatea

kazupon
kazupon commented Jul 31, 2019
View reviewed changes
ktsn
ktsn reviewed Jul 31, 2019
View reviewed changes
znck
znck reviewed Aug 3, 2019
View reviewed changes
Copy link
Member

@znck znck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate type declaration (as pointed by @mizchi) is concerning. Everything else LGTM.

haoqunjiang
haoqunjiang approved these changes Dec 8, 2019
View reviewed changes
Copy link
Member

@haoqunjiang haoqunjiang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
The type definition can be improved when vue-template-compiler releases new versions later, but that's another story anyway.

@haoqunjiang haoqunjiang merged commit ed44d6f into vuejs:master Dec 8, 2019
@kazupon kazupon deleted the tweak-patch branch December 9, 2019 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mizchi mizchi mizchi left review comments

@ktsn ktsn ktsn left review comments

@znck znck znck left review comments

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kazupon @mizchi @ktsn @znck @haoqunjiang