perf: add __NO_SIDE_EFFECTS__ comment

vuejs · Sep 5, 2023 · 8ca9f68 · 8ca9f68
1 parent 2ffe3d5
commit 8ca9f68
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 1 deletion.
diff --git a/packages/reactivity/src/collectionHandlers.ts b/packages/reactivity/src/collectionHandlers.ts
@@ -331,6 +331,7 @@ const [
   shallowReadonlyInstrumentations
 ] = /* #__PURE__*/ createInstrumentations()
 
+/*! #__NO_SIDE_EFFECTS__ */
 function createInstrumentationGetter(isReadonly: boolean, shallow: boolean) {
   const instrumentations = shallow
     ? isReadonly

diff --git a/packages/runtime-core/src/devtools.ts b/packages/runtime-core/src/devtools.ts
@@ -123,6 +123,7 @@ export const devtoolsComponentRemoved = (
   }
 }
 
+/*! #__NO_SIDE_EFFECTS__ */
 function createDevtoolsComponentHook(hook: DevtoolsHooks) {
   return (component: ComponentInternalInstance) => {
     emit(

diff --git a/packages/server-renderer/src/helpers/ssrRenderAttrs.ts b/packages/server-renderer/src/helpers/ssrRenderAttrs.ts
@@ -12,7 +12,7 @@ import {
 } from '@vue/shared'
 
 // leading comma for empty string ""
-const shouldIgnoreProp = makeMap(
+const shouldIgnoreProp = /*#__PURE__*/ makeMap(
   `,key,ref,innerHTML,textContent,ref_key,ref_for`
 )
 

diff --git a/packages/shared/src/general.ts b/packages/shared/src/general.ts
@@ -17,6 +17,7 @@ export const isOn = (key: string) => onRE.test(key)
 
 export const isModelListener = (key: string) => key.startsWith('onUpdate:')
 
+/*! #__NO_SIDE_EFFECTS__ */
 export const extend = Object.assign
 
 export const remove = <T>(arr: T[], el: T) => {

diff --git a/packages/shared/src/makeMap.ts b/packages/shared/src/makeMap.ts
@@ -5,6 +5,8 @@
  * \/\*#\_\_PURE\_\_\*\/
  * So that rollup can tree-shake them if necessary.
  */
+
+/*! #__NO_SIDE_EFFECTS__ */
 export function makeMap(
   str: string,
   expectsLowerCase?: boolean
-Original file line number
+Diff line change
@@ Expand Up / @@ -123,6 +123,7 @@ export const devtoolsComponentRemoved = ( @@
       }
     }
+    /*! #__NO_SIDE_EFFECTS__ */
     function createDevtoolsComponentHook(hook: DevtoolsHooks) {
       return (component: ComponentInternalInstance) => {
         emit(
@@ Expand Down @@