You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doctor-wu
changed the title
fix(reactivity): correct dirty assign in recursive render
fix(reactivity): correct dirty assign in allowRecurse
Jan 12, 2024
@johnsoncodehk Could you help to review this? First time to read the new reactivity system, not sure if it's totally ok, but it works to solve the issue and pass all tests
Doctor-wu
changed the title
fix(reactivity): correct dirty assign in allowRecurse
fix(reactivity): correct dirty assign in render function
Jan 12, 2024
Btw good job @Doctor-wu ! I was looking at this as well before dinner and also located the issue to be in triggerEffects. Came back and found that you have fixed it :)
It's a pity that it didn't really solve the problem. It is challenging to include numerous complex cases in the core tests. I believe it would be reasonable to allow the ecosystem to develop more complex cases. Perhaps we should run the ecosystem CI before merging
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #10082