feat(reactivity): computed
side effects no longer trigger scheduler
#10232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #10214
This PR introduces a special state
MaybeDirty_ComputedSideEffect
to avoid computed side effects triggering effect/watch/render callbacks.Although this workaround is to solve the regressions introduced by the new Reactivity System, I think this is not the accurate behavior. The reproduction of #10214 (and related issues) should indeed cause an infinite loop. I recommend throwing a warning for the case where computed produces side effects. And remove the
MaybeDirty_ComputedSideEffect
workaround in 3.5.Blocking by #10187