Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Transition): should reset enter class when have appear props #1152

Merged
merged 3 commits into from
May 11, 2020

Conversation

underfin
Copy link
Member

@underfin underfin commented May 9, 2020

fix #1150

@underfin
Copy link
Member Author

underfin commented May 9, 2020

The props with Transition component is static.Maybe we can change Transition implement use setup instead of functional.But it is complex for watch the transition enter finish.

So, I think this will be better solution.
When mount is used appear class, we can reset origin class when finish event trigger.

Well.That will be great solution to put this into BaseTransition.
1.It is make other high-order-component can re-use this.
2. it is owner of the appear props.

@yyx990803 yyx990803 merged commit 697de07 into vuejs:master May 11, 2020
@yyx990803
Copy link
Member

I think this is good enough - BaseTransition does not have the concept of classes since it's platform agnostic.

@underfin underfin deleted the fix-1150 branch May 12, 2020 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Transition) every update enter with apper class
2 participants