Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Transition): avoid applying transition hooks on comment vnode #11788

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

edison1105
Copy link
Member

close #11782

Copy link

github-actions bot commented Sep 3, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+13 B) 37.7 kB (+3 B) 33.9 kB (+32 B)
vue.global.prod.js 159 kB (+13 B) 57.5 kB (+3 B) 51.2 kB (+54 B)

Usages

Name Size Gzip Brotli
createApp 55.1 kB 21.2 kB 19.3 kB
createSSRApp 59.1 kB 22.9 kB 20.9 kB
defineCustomElement 59.8 kB 22.7 kB 20.7 kB
overall 68.8 kB (+13 B) 26.3 kB (+1 B) 23.9 kB (+2 B)

Copy link

pkg-pr-new bot commented Sep 3, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11788

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11788

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11788

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11788

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11788

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11788

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11788

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11788

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11788

vue

pnpm add https://pkg.pr.new/vue@11788

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11788

commit: df0edd8

@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Sep 3, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@yyx990803 yyx990803 merged commit 51912f8 into main Sep 4, 2024
15 checks passed
@yyx990803 yyx990803 deleted the edison/fix/11782 branch September 4, 2024 12:54
@Artem-Schander
Copy link

is this fix already released? sorry if its a dumb question, i have no idea how to find it out myself

@edison1105
Copy link
Member Author

@Artem-Schander It has been released since v3.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<Transition> retains detached DOM nodes that already left
4 participants