-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(custom-element): handle nested customElement mount w/ shadowRoot false #11861
Conversation
…executed correctly
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/runtime-core
@vue/reactivity
@vue/runtime-dom
@vue/shared
@vue/server-renderer
@vue/compat
vue
commit: |
It seems the problem related to Teleport has not been resolved. see Playground with this PR Suggestion
if (shapeFlag & ShapeFlags.ARRAY_CHILDREN) {
if(parentComponent.isCE){parentComponent.ce._teleportTarget=container}
mountChildren(
children as VNodeArrayChildren,
container,
anchor,
parentComponent,
parentSuspense,
namespace,
slotScopeIds,
optimized,
)
}
const outlets = (this._teleportTarget||this).querySelectorAll('slot') |
Thanks for your suggestion! |
❌ Deploy Preview for vue-next-template-explorer failed.
|
❌ Deploy Preview for vue-sfc-playground failed.
|
@linzhe141
but the child is not connected yet. this commit also fix #11871 more detail see #11871 (comment) |
@edison1105 THANKS!!!!!!!! |
@edison1105 incredible! I can confirm this on #11861 fixes the issues. While testing I've run into issue first described here and currently can reproduce it in playground i think this
should to be adjusted with
since |
close #11851
close #11871
this pr playground