Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested refs are no longer unwrapped in types #12044

Closed
posva opened this issue Sep 26, 2024 · 1 comment · Fixed by #12049
Closed

Nested refs are no longer unwrapped in types #12044

posva opened this issue Sep 26, 2024 · 1 comment · Fixed by #12049
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. regression scope: types

Comments

@posva
Copy link
Member

posva commented Sep 26, 2024 •
edited
Loading

Vue version

^3.5.0

Link to minimal reproduction

https://play.vuejs.org/#eNqNVNtu00AQ/ZXBL6EiWVdNeSAKVVtUCXgoqID6YoHW9iTd1t5d7Y6ToMj/zuw6cd20IBTlMmfOzJmLJ9vkwlqxajCZJXNfOGUJPFJjzzKtamscwRYcLqCFhTM1jJg6enTJMeRjKPZOkRJ6EuSZkunCaE9Q+yW8Dylejz5iVRm4Na4qX42OMj1PO0XWYoOwtpUkZAtgbh2eyRlstyChbedpsHtHHh35wDFn5T48GSddgZNaWnHvjebutiE62zl8lnCKgASMewp2ltwRWT9L06LUHFZipVZOaKRU2zo9Z1rqGk2qxklp6vOfUzEVx2mpPA1xgb6e5M6sPTrOkiXjgU7K4ArdxKEu0aH7X92DsCfaB75n+kG+zXTLYyHPS1mo5cFQClNbVaH7Yknx0p4MR/LO1p8jRq7BvpniDouHF3BPThX0DL73m67Xrw5jwYO5kHRLjCFZcvXtGjf8u3fWpmyq3X7+4rxBb6omlN7RLhtdcjcDXmziU1y90svv/mpDqP2+11BoHFLkxz19+MdEHsuditPhcLtnn8faX84PvXbS3uBiDPEjpG0Iy2h0zmuOioAfw61TJPMqqvc0Pp3wIQtSKzy4w0zjJkp1tyZ3lxZL1TM4OY0dMTSL+MnpUQT0XrODt4EbfhwfQct3Gd5SrGTVoNBv3jwazAlmmgLdKQ+NxxLIwNq4h0HEPnkXe1BiHkvsmmFhPm4Wy4XsyC9l5m/TUXby4UW/LcIF5zoc4pxz8kbZbRYhO/8dRO5lz2XWMxJv7xffUHgieH1T8Va8S9o/z+a4Tg==

Steps to reproduce

  • See test.ts

What is expected?

No type errors

What is actually happening?

The new version of Ref with a getter + setter creates a Union in UnwrapRef and UnwrapNestedRefs, breaking existing types

System Info

No response

Any additional comments?

The issue cannot be seen in the playground since it always uses latest Vue for TS.
@posva posva added scope: types ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. regression labels Sep 26, 2024
@yyx990803
Copy link
Member

yyx990803 commented Sep 27, 2024 •
edited
Loading

Caused by e0b2975

/cc @jh-leong

@jh-leong jh-leong mentioned this issue Sep 27, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. regression scope: types
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(types/ref): handle nested refs in UnwrapRef jh-leong/core
2 participants
@yyx990803 @posva