Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): allow symbol values for slot prop key #12069

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

jh-leong
Copy link
Member

@jh-leong jh-leong commented Sep 28, 2024

close #12068

Ensure unique slot keys by using the slot’s name when the key is a Symbol, without converting it to a string.

Copy link

github-actions bot commented Sep 28, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB (+12 B) 38.1 kB (+12 B) 34.2 kB (+11 B)
vue.global.prod.js 160 kB (+12 B) 58 kB (+11 B) 51.5 kB (-68 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49.1 kB 18.9 kB 17.3 kB
createApp 55.7 kB 21.4 kB 19.6 kB
createSSRApp 59.7 kB 23.1 kB 21 kB
defineCustomElement 60.4 kB 23 kB 20.9 kB
overall 69.4 kB 26.5 kB 24.1 kB

Copy link

pkg-pr-new bot commented Sep 28, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12069

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12069

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12069

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12069

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12069

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12069

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12069

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12069

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12069

vue

pnpm add https://pkg.pr.new/vue@12069

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12069

commit: 3cdd1df

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Sep 29, 2024
@yyx990803 yyx990803 merged commit d9d4d4e into vuejs:main Oct 11, 2024
13 checks passed
@jh-leong jh-leong deleted the fix/12068 branch October 11, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slot prop named 'key' can not hold a symbol value
4 participants