Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): should not intersect PublicProps with Props #12077

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

KazariEX
Copy link
Contributor

relate to #12059

$props: MakeDefaultsOptional extends true
? Partial<Defaults> & Omit<Prettify<P> & PublicProps, keyof Defaults>
: Prettify<P> & PublicProps

image

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB 38.1 kB 34.3 kB
vue.global.prod.js 160 kB 58 kB 51.5 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49 kB 18.9 kB 17.2 kB
createApp 55.6 kB 21.4 kB 19.6 kB
createSSRApp 59.6 kB 23.1 kB 21 kB
defineCustomElement 60.4 kB 23 kB 20.9 kB
overall 69.3 kB 26.5 kB 24.1 kB

Copy link

pkg-pr-new bot commented Sep 29, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12077

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12077

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12077

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12077

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12077

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12077

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12077

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12077

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12077

vue

pnpm add https://pkg.pr.new/vue@12077

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12077

commit: c9884bd

@KazariEX KazariEX changed the title fix(type): should not intersect PublicProps with Props fix(types): should not intersect PublicProps with Props Sep 29, 2024
@edison1105
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Sep 30, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros failure failure
vuetify success success
vueuse success failure
vue-simple-compiler success success

@edison1105 edison1105 added the ready to merge The PR is ready to be merged. label Sep 30, 2024
@yyx990803 yyx990803 merged commit 6f85894 into vuejs:main Oct 3, 2024
13 checks passed
@KazariEX KazariEX deleted the fix/props-union-type branch October 8, 2024 14:49
@edison1105
Copy link
Member

@KazariEX
This PR caused the nr test dts.spec.ts test case to fail after upgrading vue to v3.5.11 in language-tools. This is also the reason why language-tools has been failing continuously in ecosystem-ci.
See https://github.com/vuejs/ecosystem-ci/actions/runs/11321265946/job/31480065218.

If these snapshots are expected, perhaps we should update them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged. scope: types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants