Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition are not ignoring html comments #1352

Closed
AlexandreBonaventure opened this issue Jun 12, 2020 · 2 comments
Closed

Transition are not ignoring html comments #1352

AlexandreBonaventure opened this issue Jun 12, 2020 · 2 comments

Comments

@AlexandreBonaventure
Copy link
Contributor

Version

3.0.0-beta.14

Reproduction link

https://jsfiddle.net/bfag54kh/

Steps to reproduce

Put an HTML comment among Transition's children

What is expected?

It should ignore HTML comment and act as the comment is not here

What is actually happening?

It is throwing a warning
"[Vue warn]: Template compilation error: Transition expects exactly one child element or component.

If you remove the comment from the repro it is going to remove the warning
@underfin underfin mentioned this issue Jun 13, 2020
Closed
@underfin
Copy link
Member

Look like it is intentional. I fixed other warn for invalid expression with v-else on beta.15.

@SilentDepth
Copy link

Seems like this problem still exists in Vue 3.0.5 when using bundler.

Repro: https://codesandbox.io/s/vue-3-transition-comment-issue-chjvl

@posva posva mentioned this issue Apr 16, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: should not warn with v-else underfin/vue-next
3 participants
@AlexandreBonaventure @SilentDepth @underfin