Skip to content

Conversation

@edison1105
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 21, 2025 03:26
@coderabbitai
Copy link

coderabbitai bot commented Dec 21, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/fix/mergeVModelHandlers

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 85.5 kB 30 kB 26.4 kB
runtime-dom.global.prod.js 108 kB 40.6 kB 36.6 kB
vue.global.prod.js 167 kB 60.7 kB 54 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.3 kB 18.9 kB 17.3 kB
createApp 57.3 kB 22 kB 20.1 kB
createApp + vaporInteropPlugin 96.4 kB 35.6 kB 32.2 kB
createVaporApp 42.2 kB 15.6 kB 14.2 kB
createSSRApp 61.6 kB 23.9 kB 21.7 kB
defineCustomElement 63.4 kB 23.9 kB 21.8 kB
overall 72.1 kB 27.3 kB 24.9 kB

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 21, 2025

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14229
npm i https://pkg.pr.new/@vue/compiler-core@14229
yarn add https://pkg.pr.new/@vue/compiler-core@14229.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14229
npm i https://pkg.pr.new/@vue/compiler-dom@14229
yarn add https://pkg.pr.new/@vue/compiler-dom@14229.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14229
npm i https://pkg.pr.new/@vue/compiler-sfc@14229
yarn add https://pkg.pr.new/@vue/compiler-sfc@14229.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14229
npm i https://pkg.pr.new/@vue/compiler-ssr@14229
yarn add https://pkg.pr.new/@vue/compiler-ssr@14229.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14229
npm i https://pkg.pr.new/@vue/compiler-vapor@14229
yarn add https://pkg.pr.new/@vue/compiler-vapor@14229.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14229
npm i https://pkg.pr.new/@vue/reactivity@14229
yarn add https://pkg.pr.new/@vue/reactivity@14229.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14229
npm i https://pkg.pr.new/@vue/runtime-core@14229
yarn add https://pkg.pr.new/@vue/runtime-core@14229.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14229
npm i https://pkg.pr.new/@vue/runtime-dom@14229
yarn add https://pkg.pr.new/@vue/runtime-dom@14229.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14229
npm i https://pkg.pr.new/@vue/runtime-vapor@14229
yarn add https://pkg.pr.new/@vue/runtime-vapor@14229.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14229
npm i https://pkg.pr.new/@vue/server-renderer@14229
yarn add https://pkg.pr.new/@vue/server-renderer@14229.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14229
npm i https://pkg.pr.new/@vue/shared@14229
yarn add https://pkg.pr.new/@vue/shared@14229.tgz

vue

pnpm add https://pkg.pr.new/vue@14229
npm i https://pkg.pr.new/vue@14229
yarn add https://pkg.pr.new/vue@14229.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14229
npm i https://pkg.pr.new/@vue/compat@14229
yarn add https://pkg.pr.new/@vue/compat@14229.tgz

commit: a6d7850

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the merging of component v-model onUpdate:* handlers with explicitly provided handlers of the same name. When a component has both v-model and an explicit @update:modelValue handler, they are now correctly merged into an array of handlers instead of overwriting each other.

Key changes:

  • Refactored handler generation to group handlers by key name and merge multiple handlers into arrays
  • Split the extraWrap parameter in genEventHandler into two separate parameters (asComponentProp and extraWrap) for clearer semantics
  • Moved v-model event handler and modifier generation from genProp into genStaticProps for proper deduplication

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/compiler-vapor/src/generators/event.ts Split extraWrap parameter into asComponentProp and extraWrap for clarity; updated comments and logic
packages/compiler-vapor/src/generators/component.ts Refactored genStaticProps to group and merge handlers by key; moved v-model handler generation; removed genModelEvent and genModelModifiers helper functions; updated genDynamicProps to handle v-model with dynamic arguments
packages/compiler-vapor/__tests__/transforms/vModel.spec.ts Added test for merging v-model with explicit @update:modelValue handler; added transformVOn to test configuration; updated existing test expectations
packages/compiler-vapor/__tests__/transforms/__snapshots__/vModel.spec.ts.snap Updated snapshots with improved formatting and new test case snapshot showing merged handlers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@edison1105 edison1105 added the scope: vapor related to vapor mode label Dec 21, 2025
@edison1105 edison1105 merged commit e6bff23 into minor Dec 22, 2025
22 of 23 checks passed
@edison1105 edison1105 deleted the edison/fix/mergeVModelHandlers branch December 22, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: vapor related to vapor mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants