Prop validation uses StringTag, which invalidates valid props

[SebastianSpeitel]

Version

3.0.0-rc.5

Reproduction link

https://github.com/SebastianSpeitel/vue-bug-stringtag

Steps to reproduce

Build and run Vue App.
Then look in the console.

// App.vue
<template>
  <div>
    <Comp :obj="obj" :obj2="obj" :obj3="obj" />
  </div>
</template>

<script>
import Comp from "./components/Component.vue";

export default {
  components: {
    Comp
  },
  setup() {
    const obj = {
      get [Symbol.toStringTag]() {
        return "NotObject";
      }
    };

    return { obj };
  }
};
</script>

// components/Component.vue
<template>
  <div />
</template>

<script>
export default {
  name: "HelloWorld",
  props: {
    obj: Object,
    obj2: { type: Object },
    obj3: { validator: o => typeof o === "object" }
  }
};
</script>

What is expected?

An Object with an overridden Symbol.toStringTag getter should be a valid prop for type:Object

What is actually happening?

The type assertion uses the StringTag to compare the type of objects when the prop type is the Object constructor.

---

For type assertion of objects in assertType [2], toRawType [3] is used, where it would be more intuitive to just use typeof prop === 'object' && prop !== null.

[2]:

https://github.com/vuejs/vue-next/blob/304830a764cd9f28098cfb0ac0e520e1bb2f57c7/packages/runtime-core/src/componentProps.ts#L489-L510

[3]:

https://github.com/vuejs/vue-next/blob/304830a764cd9f28098cfb0ac0e520e1bb2f57c7/packages/shared/src/index.ts#L76-L78