-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HMR doesn't update component which uses events #1942
Comments
A similar error with custom directives. Component properties are not updated while a custom directive is set. |
It seems to me that checking for type .__ hmrId is unnecessary : https://github.com/vuejs/vue-next/blob/03e26845e2c220b1350a35179acf3435e2711282/packages/runtime-core/src/componentProps.ts#L201 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Version
3.0.0-rc.7
Reproduction link
https://github.com/Kadeluxe/051c3513-84bf-42f9-b3f6-a0d35fc43f9c
Steps to reproduce
What is expected?
HMR works and component gets updated
What is actually happening?
HMR doesn't update component
This is the diff from vue-cli generated project with working reproduction.
Clone it, run
serve
and changetext
prop value ofTest
insideApp.vue
. Unless you remove@click
event, HMR won't updateTest
component at all.The text was updated successfully, but these errors were encountered: