Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should be able to parse decorators in script lang="ts" & jsx #2088

Merged
merged 2 commits into from
Sep 15, 2020
Merged

fix: should be able to parse decorators in script lang="ts" & jsx #2088

merged 2 commits into from
Sep 15, 2020

Conversation

haoqunjiang
Copy link
Member

@haoqunjiang
Copy link
Member Author

Question: shall we fail gracefully if an error is thrown during parsing?
Because users may have configured custom babel plugins, and if they are not using <script setup>, they shouldn't have to understand how to configure the babelParserPlugins option.

@haoqunjiang
fix: should also support parsing jsx
9eed94e 
Added to `compileScript` instead of `babelParserDefaultPlugins` because
it's not needed for template expression parsing
@haoqunjiang haoqunjiang changed the title fix: should be able to parse decorators in script lang="ts" fix: should be able to parse decorators in script lang="ts" & jsx Sep 10, 2020
@haoqunjiang haoqunjiang mentioned this pull request Sep 11, 2020
Closed
@yyx990803 yyx990803 merged commit 273d19a into vuejs:master Sep 15, 2020
@yyx990803
Copy link
Member

Re: shall we fail gracefully if an error is thrown during parsing?

I added graceful fallback for failed parse when there is only <script> in c67e78a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 Awaiting requested review from yyx990803

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@haoqunjiang @yyx990803