Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-core): avoid generating useless createVNode helper #2938

Merged
merged 4 commits into from
Mar 25, 2021
Merged

fix(compiler-core): avoid generating useless createVNode helper #2938

merged 4 commits into from
Mar 25, 2021

Conversation

HcySunYang
Copy link
Member

close: #2739

cexbrayat
cexbrayat suggested changes Feb 4, 2021
View reviewed changes
Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just two tiny nits.

packages/compiler-core/src/transform.ts Show resolved Hide resolved
packages/compiler-core/src/transforms/vIf.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Feb 4, 2021

Size report

Path Size
vue.global.prod.js 40.66 KB (+0.26% 🔺)
runtime-dom.global.prod.js 26.95 KB (0%)
size-check.global.prod.js 16.31 KB (0%)

@HcySunYang
Copy link
Member Author

@cexbrayat thank you

@HcySunYang HcySunYang added 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: compiler labels Feb 4, 2021
@yyx990803 yyx990803 merged commit 7715c49 into vuejs:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cexbrayat cexbrayat cexbrayat requested changes

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

template compile will generate useless createVNode import when the component can be statically optimized
3 participants
@HcySunYang @cexbrayat @yyx990803