-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(types): ComponentInstance type #5408
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-next-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vue-sfc-playground ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vuejs-coverage ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pikax
added
🍰 p2-nice-to-have
Priority 2: this is not breaking anything but nice to have it addressed.
scope: types
labels
Feb 11, 2022
This is technically a feature so grouping it under 3.3 for now |
# Conflicts: # packages/dts-test/componentInstance.test-d.tsx # packages/dts-test/defineComponent.test-d.tsx
Size ReportBundles
Usages
|
sxzz
approved these changes
Oct 6, 2023
sxzz
force-pushed
the
minor
branch
4 times, most recently
from
October 20, 2023 09:35
5d93a55
to
06ad749
Compare
yyx990803
changed the title
types(runtime-core): ComponentInstance type
feat(types): ComponentInstance type
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🍰 p2-nice-to-have
Priority 2: this is not breaking anything but nice to have it addressed.
ready to merge
The PR is ready to be merged.
scope: types
version: minor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type to replace the
InstanceType<typeof MyComp>
The advantages of using this type, is to also allow other valid typed components to be resolved, because the
InstanceType
, relies on theConstructor
type.