Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): pass options to plugins #561

Merged
merged 1 commit into from
Dec 24, 2019

Conversation

fnlctrl
Copy link
Member

@fnlctrl fnlctrl commented Dec 24, 2019

No description provided.

if (installedPlugins.has(plugin)) {
__DEV__ && warn(`Plugin has already been applied to target app.`)
} else if (isFunction(plugin)) {
installedPlugins.add(plugin)
plugin(app)
plugin(app, ...options)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use arguments to avoid overhead of transpiled code?

@yyx990803 yyx990803 merged commit 4d20981 into vuejs:master Dec 24, 2019
@fnlctrl fnlctrl deleted the plugin-options branch December 24, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants