fix(compiler): only transform relative asset URLs #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyx990803
requested changes
Jan 16, 2020
| context | ||
| ) | ||
| let exp: ExpressionNode | ||
| if (isRelativeUrl(attr.value.content)) { |
There was a problem hiding this comment.
I think we should simply return early if the URL is absolute. This keeps src a static attribute and allows the entire img element to be hoisted.
There was a problem hiding this comment.
Awesome, this didn't even occur to me to simply return. Changed it here accordingly and reverted the condition brackets.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue first reported in
vue-loader: vuejs/vue-loader#1632Absolute asset URLs, such as those that start with a forward-slash
/or are evenhttp(s)://URLs are currently interpreted as relative URLs and their path is transformed into animportexpression by the SFC compiler.This PR adds a utility method
isRelativeUrland uses it to differentiate between URLs that need to be imported and thus transformed, and those that do not.I can also imagine other names for the helper method, such as
requiresTransform.I only started looking into the source yesterday, so if the solution presented in this PR does not match with how you would solve this, feel free to give pointers and close this.