Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hmr): fix the page not updating when using computed value as slot… #7158

Closed
wants to merge 1 commit into from

Conversation

zhangzhonghe
Copy link
Member

… (#7155)

fix #7155

I found that there are component libraries (e.g. here) that render component slots by computed wrapping and then rendering them dynamically in the template. This can lead to a situation where HMR does not cause the page to update when the user changes the template content.

@zhangzhonghe zhangzhonghe added the 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. label Nov 17, 2022
@jaytonic
Copy link

jaytonic commented Jan 14, 2023

Hi,
Any chance that someone could validate this PR? It would really be helpfull :) It is really a pain that the HMR is not updating the page when developing with such libraries.

@haoqunjiang haoqunjiang added 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. and removed 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Apr 14, 2023
@martinszeltins
Copy link

martinszeltins commented Apr 14, 2023

Hi,
Any chance that someone could validate this PR? It would really be helpfull :) It is really a pain that the HMR is not updating the page when developing with such libraries.

I am also waiting on this fix. Super annoying that HMR does not work.

@zhangzhonghe Is there any way I can use this fix today somehow?

@yyx990803 yyx990803 closed this in 94fa67a Apr 20, 2023
IAmSSH pushed a commit to IAmSSH/core that referenced this pull request May 14, 2023
@zhangzhonghe zhangzhonghe deleted the fix-7155 branch May 7, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HMR not reloading the page
4 participants