Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): Infinite Loop Detection should throw a real error #7447

Merged
merged 2 commits into from
Dec 19, 2023
Merged

fix(runtime-core): Infinite Loop Detection should throw a real error #7447

merged 2 commits into from
Dec 19, 2023

Conversation

smallnine9
Copy link
Contributor

(close #7437)

zhangzhonghe
zhangzhonghe approved these changes Jan 2, 2023
View reviewed changes
Copy link
Member

@zhangzhonghe zhangzhonghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

sxzz
sxzz requested changes Jan 2, 2023
View reviewed changes
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment for you.

@smallnine9 smallnine9 requested a review from sxzz January 2, 2023 17:39
@netlify
Copy link

netlify bot commented Jan 2, 2023

❌ Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit aad8bcb
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/63b31660647b0e0008dfce46

@smallnine9 smallnine9 closed this Mar 3, 2023
@7Z0nE
Copy link

7Z0nE commented Apr 26, 2023 •
edited
Loading

@smallnine9 Why was this closed? This PR is much needed.

@yyx990803 yyx990803 reopened this Dec 19, 2023
@yyx990803 yyx990803 changed the base branch from main to minor December 19, 2023 08:54
@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 87.1 kB 33.1 kB 29.9 kB
vue.global.prod.js 133 kB 50 kB 44.8 kB

Usages

Name Size Gzip Brotli
createApp 48.4 kB 19 kB 17.4 kB
createSSRApp 51.6 kB 20.3 kB 18.5 kB
defineCustomElement 50.7 kB 19.8 kB 18.1 kB
overall 61.7 kB 23.9 kB 21.7 kB

@vuejs vuejs deleted a comment from codspeed-hq bot Dec 19, 2023
@yyx990803 yyx990803 merged commit 1d79b64 into vuejs:minor Dec 19, 2023
5 of 6 checks passed
@sxzz sxzz mentioned this pull request Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangzhonghe zhangzhonghe zhangzhonghe approved these changes

@sxzz sxzz Awaiting requested review from sxzz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vue infinite loop detection should throw a real error in dev, not just log a warning to console
5 participants
@smallnine9 @7Z0nE @sxzz @zhangzhonghe @yyx990803