fix(playground): fix github button style #7722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| > | ||
| <GitHub /> | ||
| </a> | ||
| <button title="View on GitHub" class="github" @click="openGithub"> |
There was a problem hiding this comment.
Using button instead of a tag to open a new page is not conducive to SEO, maybe you need to rethink how to solve it
There was a problem hiding this comment.
The source code href on github really need to SEO? 😲😲
|
We should just remove the |
BeADre
changed the title
|
@Justineo done |
Justineo
reviewed
Feb 16, 2023
|
|
||
| .links .github:hover { | ||
| color: var(--highlight); | ||
| } |
There was a problem hiding this comment.
I think it's better to merge this into L292:300:
.links > button,
.links > a {
padding: 1px 6px;
color: var(--btn);
}
.links > button:hover,
.links > a:hover {
color: var(--highlight);
}
Justineo
approved these changes
Feb 17, 2023
sxzz
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size of button content is larger than inner a tag and has set
cursor: pointerso when we click the padding part of button will not open github