-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(runtime-core): pre jobs without an id should run first #7746
Merged
yyx990803
merged 5 commits into
vuejs:main
from
skirtles-code:pre-watch-without-component
Aug 19, 2024
Merged
fix(runtime-core): pre jobs without an id should run first #7746
yyx990803
merged 5 commits into
vuejs:main
from
skirtles-code:pre-watch-without-component
Aug 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
Size ReportBundles
Usages
|
# Conflicts: # packages/runtime-core/src/scheduler.ts
commit: @vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
watch()
is used outside of a component, the job won't be assigned an id. This leads to it running last, after component rendering:SFC Playground
This is a regression in 3.2.38, introduced by 78c199d. With 3.2.37 the watcher runs first, as expected.
If someone actually wants a 'global' watcher to run after rendering they can use
flush: 'post'
instead.In the early 3.0.0 betas,
pre
jobs were assigned an id of-1
, so the default value ofInfinity
wasn't used. Once the separatepre
queue was introduced the id became irrelevant, so it was removed. However, 3.2.38 movedpre
jobs back into the main queue. Forwatch()
calls inside components, this assigns the job an actual id, to ensure they are run just before the component's rendering job. But forwatch()
calls outside components, no id is assigned and it falls back toInfinity
.My change uses
-1
as the default id forpre
jobs.SFC Playground - This PR