Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling inside the effectScope #8284

Closed
euaaaio opened this issue May 11, 2023 · 3 comments · Fixed by #8397
Closed

Error handling inside the effectScope #8284

euaaaio opened this issue May 11, 2023 · 3 comments · Fixed by #8397
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.

Comments

@euaaaio
Copy link

euaaaio commented May 11, 2023

Vue version

3.3.1

Link to minimal reproduction

https://play.vuejs.org/#eNqNVE2PmzAQ/SsjLiESwbvaW5REW0V76LmHPZSqojAEtmBbtkkOEf+9448mhCxpT8jP8/Hem8Hn6IuU6bHHaB1tdKEaaUCj6eUu400nhTLwppRQ+9wUNSqolOhgkbIxaNMXt+FY7gUdOXJzmzK6CGkb5ttSQzoY7GSbG6QTwGbcxSGZ8dioDPOhN4wI2rBLqSiJPLdVl8v0QwtOYs+uXLjQWbQGh1iMeNlzFtXGSL1mrOfy9yEtRMde6Y6pnpumw1UputeX9CV9ZmWjzRhOUXerX0qcNLnzQdWTUW1G4BHVSiEvUaF62GsSO+43ubrraVsOGR9I/mfWzw/8DFhVWJhvhZCYQM8VVgmcrLUwhHH62ZEiXgiuDfQaQ5N3F7eFuCmXsN15W11y7CcYO9hVtTHBGo+GGQCYmpQAx5Pfp3jh2qJvAa7HYumDh1DhDE3XYdnQyNdgVI9WPQBF0XfE0yW/N6Z+u6qc5/uX2R1f4va1TOBnAoLvW8x5L28ltEjOhuIjQ+NAG/xlSmsTT8TD1M74+WkJjAEXBgq34uU1lvDP3fL6wAt0SPDNpkzKDBdWFzX3rDxhbYS8irgmzvKY6/qfg5sZmfXk8eshd8FDuCz+htk9v30bpk/Zox9D8BAtTU+FE6ClmP0n3LZqmr7dnO8/iG3GJwViWo5gsc0RLaatOMToTPX56TFve0xlr+uAK2KlOFR5q5E8+ocLuhVmRwH2422B46qptlkU6rfID6aGHTxl0e5MP7+nPQz3Zg1/AHm8EqM=

Steps to reproduce

Just open the reproduction. onErrorCaptured can handle any commented error except one, uncommented.

What is expected?

Thrown error from watch inside the useErroredWatch composable inside effectScope should have been handled by onErrorCaptured.

What is actually happening?

Error not thrown but I see warning about unhandled error.

System Info

No response

Any additional comments?

No response

@euaaaio
Copy link
Author

euaaaio commented May 12, 2023

@euaaaio euaaaio changed the title Error handling warning from watch within effectScope Error handling inside the effectScope May 12, 2023
@edison1105 edison1105 added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label May 15, 2023
@skirtles-code
Copy link
Contributor

The warning is no longer shown as of 3.4.4. The relevant change seems to be #9948. I'm not sure whether that fully fixes the issue or not, but the reproduction given here does seem to be working since 3.4.4.

Note that the original reproduction link is set to 3.3.1 in the import map, so despite appearances it isn't actually using the latest main.

@yyx990803
Copy link
Member

Both cases are no longer reproducible in latest 3.4 and also in 3.5 alpha.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants