-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compiler-core): support Symbol in template #9069
Conversation
Size ReportBundles
Usages
|
I think our goal is not to make it as comprehensive as possible, but sufficient to meet actual needs. I don't think there are actual use cases for most of the added globals here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in code perspective, waiting for more discussion.
- necessary?
- minor?
… commit removes obsolete global variables from the globalsAllowList.ts file to simplify and optimize the code
…ects and functions
merge PR #7018 first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A unit test is needed in packages/compiler-core/__tests__/transforms/transformExpressions.spec.ts
relate #9027