Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-sfc): generate more treeshaking friendly code #9507

Merged
merged 2 commits into from
Nov 30, 2023
Merged

fix(compiler-sfc): generate more treeshaking friendly code #9507

merged 2 commits into from
Nov 30, 2023

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Oct 30, 2023 •
edited
Loading

close #9500
ensure mergeDefaults and mergeModels can be treeshaken

@github-actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.5 kB 32.9 kB 29.7 kB
vue.global.prod.js 132 kB 49.6 kB 44.5 kB

Usages

Name Size Gzip Brotli
createApp 47.9 kB 18.9 kB 17.2 kB
createSSRApp 51.2 kB 20.2 kB 18.4 kB
defineCustomElement 50.3 kB 19.7 kB 17.9 kB
overall 61.3 kB 23.7 kB 21.6 kB

@edison1105 edison1105 changed the title fix(compiler-sfc): ensure mergeDefaults code can be treeshaken fix(compiler-sfc): generate more treeshaking friendly code Oct 30, 2023
@haoqunjiang haoqunjiang added 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready for review This PR requires more reviews labels Oct 31, 2023
@haoqunjiang haoqunjiang added ready to merge The PR is ready to be merged. and removed ready for review This PR requires more reviews labels Nov 1, 2023
@yyx990803 yyx990803 merged commit 8d74ca0 into vuejs:main Nov 30, 2023
11 checks passed
@94726 94726 mentioned this pull request Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baiwusanyu-c baiwusanyu-c baiwusanyu-c approved these changes

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged.
Projects
Issue / PR Management
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

withDefaults object variable results in non-tree-shakable component
4 participants
@edison1105 @haoqunjiang @baiwusanyu-c @yyx990803