Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(runtime-core): add h function overload #9756

Merged
merged 7 commits into from
Dec 11, 2023

Conversation

Alfred-Skyblue
Copy link
Member

@Alfred-Skyblue Alfred-Skyblue commented Dec 5, 2023

This PR introduces an overload for the h function to retrieve element types from HTMLElementTagNameMap. Additionally, it utilizes HTMLElementEventMap to obtain types for element events, allowing for better event binding within the h function.

image image image

Copy link

github-actions bot commented Dec 5, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 87 kB 33.1 kB 29.9 kB
vue.global.prod.js 133 kB 49.9 kB 44.8 kB

Usages

Name Size Gzip Brotli
createApp 48.3 kB 19 kB 17.4 kB
createSSRApp 51.5 kB 20.3 kB 18.5 kB
defineCustomElement 50.7 kB 19.8 kB 18 kB
overall 61.7 kB 23.9 kB 21.7 kB

@Alfred-Skyblue
Copy link
Member Author

/cc @pikax Do you think this PR is helpful?

@pikax
Copy link
Member

pikax commented Dec 5, 2023

@Alfred-Skyblue yes, even if very few people use it, is still good for the overall vue typescript usage :)

@pikax pikax added ready to merge The PR is ready to be merged. scope: types 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Dec 5, 2023
@haoqunjiang
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Dec 7, 2023

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure success
nuxt success success
pinia success success
quasar success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success success
vuetify success success
vueuse success success
vue-simple-compiler success success

@haoqunjiang
Copy link
Member

The language-tools ecosystem-ci failure isn't related to this PR.

Copy link

codspeed-hq bot commented Dec 8, 2023

CodSpeed Performance Report

Merging #9756 will not alter performance

Comparing Alfred-Skyblue:types/runtime-core/h-overload (6c7acca) with main (213eba4)

Summary

✅ 53 untouched benchmarks

@yyx990803 yyx990803 changed the base branch from main to minor December 11, 2023 10:18
@yyx990803 yyx990803 changed the base branch from minor to main December 11, 2023 10:20
@yyx990803 yyx990803 changed the base branch from main to minor December 11, 2023 14:07
@yyx990803 yyx990803 merged commit a625376 into vuejs:minor Dec 11, 2023
13 checks passed
@Alfred-Skyblue Alfred-Skyblue deleted the types/runtime-core/h-overload branch December 11, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: types
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants