Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(watch): cleanup scope's effects after effect stopped #9978

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

yangmingshan
Copy link
Contributor

When this cleanup was first introduced, effectScope did not exist yet. For today, I think it's reasonable to expand this cleanup to general effectScope.

Copy link

github-actions bot commented Jan 3, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 89.4 kB (-3 B) 34 kB (-5 B) 30.7 kB
vue.global.prod.js 146 kB (-3 B) 53.3 kB (+20 B) 47.6 kB (+39 B)

Usages

Name Size Gzip Brotli
createApp 49.7 kB (-11 B) 19.5 kB 17.8 kB (-27 B)
createSSRApp 53.1 kB (-11 B) 20.8 kB (+2 B) 19 kB (+12 B)
defineCustomElement 52 kB (-11 B) 20.2 kB (-1 B) 18.5 kB (+25 B)
overall 63.2 kB (-11 B) 24.4 kB (-1 B) 22.2 kB (+3 B)

@yyx990803 yyx990803 merged commit d2d8955 into vuejs:main Jan 4, 2024
11 checks passed
@yyx990803
Copy link
Member

I would consider this a fix since previously the effect isn't removed if the watcher is created in a detached scope.

@yangmingshan yangmingshan deleted the unwatch branch January 4, 2024 09:35
yangmingshan added a commit to vue-mini/vue-mini that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants