Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(runtime-core): optimizing type inference with defaults #9998

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

yangxiuxiu1115
Copy link
Contributor

@yangxiuxiu1115 yangxiuxiu1115 commented Jan 4, 2024

Close #9899, type optimization has been carried out.

Copy link

github-actions bot commented Jan 4, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 98.7 kB 37.4 kB 33.7 kB
vue.global.prod.js 156 kB 57.2 kB 50.9 kB

Usages

Name Size Gzip Brotli
createApp 54.1 kB 21 kB 19.2 kB
createSSRApp 58.1 kB 22.6 kB 20.6 kB
defineCustomElement 58.8 kB 22.5 kB 20.5 kB
overall 67.7 kB 26 kB 23.6 kB

@yangxiuxiu1115 yangxiuxiu1115 deleted the fix/withdefaults branch January 6, 2024 16:23
@yangxiuxiu1115 yangxiuxiu1115 restored the fix/withdefaults branch January 8, 2024 12:22
@yangxiuxiu1115 yangxiuxiu1115 reopened this Jan 8, 2024
@yangxiuxiu1115 yangxiuxiu1115 changed the title fix(types): optimizing type inference with defaults types(runtime-core): optimizing type inference with defaults Jan 8, 2024
@pikax
Copy link
Member

pikax commented Jan 19, 2024

Thanks for this, can you add a test for this please?

@pikax pikax added need test The PR has missing test cases. scope: types labels Jan 19, 2024
@haoqunjiang haoqunjiang removed the need test The PR has missing test cases. label May 20, 2024
@edison1105
Copy link
Member

Could you please resolve the conflicts?

@edison1105
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Aug 16, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success failure
pinia success failure
primevue success failure
quasar success failure
radix-vue success failure
router success failure
test-utils success failure
vant success failure
vite-plugin-vue success failure
vitepress success failure
vue-i18n success failure
vue-macros success failure
vuetify success failure
vueuse success failure
vue-simple-compiler success failure

@edison1105 edison1105 added the ready to merge The PR is ready to be merged. label Aug 16, 2024
@yyx990803 yyx990803 merged commit 44973bb into vuejs:main Aug 19, 2024
11 checks passed
@yangxiuxiu1115 yangxiuxiu1115 deleted the fix/withdefaults branch August 19, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged. scope: types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

withDefaults doesn't respect type definition of defineProps - able to add unknown property.
6 participants