Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): fix resolving inheritAttrs from mixins #3742

Merged
merged 4 commits into from
May 28, 2021
Merged

fix(runtime-core): fix resolving inheritAttrs from mixins #3742

merged 4 commits into from
May 28, 2021

Conversation

edison1105
Copy link
Member

fix #3741

@edison1105 edison1105 requested a review from yyx990803 May 13, 2021 01:24
@edison1105
chore: change solution
1243c97 
chore: improve code

chore: improve code
yyx990803
yyx990803 reviewed May 28, 2021
View reviewed changes
packages/runtime-core/src/componentOptions.ts Outdated
resolveInstanceAssets(instance, options, FILTERS)
}

if (inheritAttrs !== undefined) instance.inheritAttrs = inheritAttrs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: should only set this if the base component doesn't have the option (which should have highest priority)

@yyx990803 yyx990803 merged commit d6607c9 into vuejs:master May 28, 2021
@dxvladislavvolkov dxvladislavvolkov mentioned this pull request Jun 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 yyx990803 requested changes

@Gavin-Gong Gavin-Gong Gavin-Gong requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inheritAttrs: false does not work in a mixin
3 participants
@edison1105 @yyx990803 @Gavin-Gong