-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncaught ReferenceError: o is not defined #514
Comments
I can't reproduce this. Also, the code you posted doesn't exist. Here is the compiled code in the extension: document.addEventListener("contextmenu", t=>{
let n = t.target;
if (n) {
for (; !n.__vue__ && n.parentElement; )
n = n.parentElement;
const t = n.__vue__;
if (t)
return e.__VUE_DEVTOOLS_CONTEXT_MENU_HAS_TARGET__ = !0,
void (e.__VUE_DEVTOOLS_CONTEXT_MENU_TARGET__ = t)
}
e.__VUE_DEVTOOLS_CONTEXT_MENU_HAS_TARGET__ = null,
e.__VUE_DEVTOOLS_CONTEXT_MENU_TARGET__ = null
}
) Try to remove and reinstall the extension. |
build with this commit: a79d9c5 |
#525 Possible related issues |
Got a same issue. |
+1 |
Got the same issue.
|
@Akryum After your fix in #528, I've also seen this, the first time Vue-Devtools is run. This can now be seen in the same sample here (the same url sample in #528). This seems to happen only the first time Vue-Devtools is initialized. Steps to reproduce
Sometimes this error pops right away on the page. Sometimes you need to click on the page a few times and it will display the error instead of the rendered content. In one of my project, it displays in the developer tools' console window. When reloading the page the second time (without closing Vue-devtools), the error is gone. |
@ratiw I can't reproduce on the branch. |
@Akryum After revisit it again, it actually happens when I "right-click" the window. Please see the attached gif. |
Confirmed, mouse right-click trigged it in my Chrome also. |
Same issue on my end guys |
Same issue here, when right clicked on any page, version tested: 4.1.0 |
Seems to be related to the contextual menu that displays the "inspect vue component" with latest Vue.js, I'm installing it and it's fresh, also having the issue. |
Fixed in #553 |
@anteriovieira Well, I'm using NWjs (node-webkit) with Vue + Vue DevTools and the error still remains. |
@f3l1x, the fix should come in the next version. |
You should release that version ASAP. Or even consider disabling the current version of the plugin altogether until you have released that version: |
Are your users using the Vue devtools? |
As soon as you have a certain user base, there are some among them, who are using it. Do you always disable the plugin when you don't develop with vue? I don't. (or rather: I didn't). |
Until 4.1.1 is out they can disable it then. |
|
The point is: How do I tell them, that it's not my page that is broken, but its the damn plugin that is totally unrelated? I cannot send an email to all my users and tell them about the plugin. I don't even have their contact data. When will 4.1.1. be out? |
@anteriovieira This can happen even if the devtools are not open. |
Why don't you have any mean of supporting your users? |
Very soon. |
4.1.1 has been pushed to chrome web store, it should be live any time. |
4.1.1 is out, not experiencing this bug anymore on my end (user agent: |
Thanks for the fix @Akryum! This issue also affected the extension on Firefox and it is now fixed as well. Please ignore the complainers. Users need to understand that any time they install an extension and grant permission to inject javascript on any page, they are opening 3rd party sites up to breakage. That's not on you at all. Developers should know better. |
Confirm, it's fixed for my and NW.js environment. |
When simulating mobile devices...Long press a button, tools report error about a second later.
Edit: Or right click and it immediately report the error
Version
4.0.0
Browser and OS info
Chrome 63/ Win 10 FCU
Steps to reproduce
1.Long press a button
2.report error
What is expected?
No mistake
What is actually happening?
report error
The text was updated successfully, but these errors were encountered: