Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huge performance impact #548

Closed
KaelWD opened this issue Jul 26, 2024 · 4 comments · Fixed by #595
Closed

Huge performance impact #548

KaelWD opened this issue Jul 26, 2024 · 4 comments · Fixed by #595
Labels
good first issue Good for newcomers perf Performance issue

Comments

@KaelWD
Copy link

KaelWD commented Jul 26, 2024

v6 was pretty bad on pages with lots of components but it didn't really matter until you activated the vue tab. v7 seems to be doing a bunch of work as soon as chrome devtools is opened, adding 100ms+ to every interaction.

This is me just scrolling through a list in the vuetify documentation in a fresh tab that hasn't used vue devtools yet:
Screenshot_20240726_151448
The green column is vue rendering in 3ms, all the purple is 140ms of vue devtools prepare.js.

@KaelWD
Copy link
Author

KaelWD commented Jul 26, 2024

I can't actually get v6 to have a noticeable impact on this page even with update tracking enabled, so v7 really is a huge step backwards currently.

@webfansplz
Copy link
Member

We are about to optimize the initialization overhead of devtools to make it as on-demand as possible (before opening the devtools client). Additionally, we want to understand where v7's performance has not improved compared to v6 after opening the devtools client. We've done some work in this area, and if you could provide a small reproducible example to help us investigate this regression, it would be greatly appreciated.

@webfansplz webfansplz added good first issue Good for newcomers perf Performance issue labels Jul 26, 2024
@KaelWD
Copy link
Author

KaelWD commented Jul 26, 2024

This was https://github.com/vuetifyjs/vuetify

pnpm build vuetify api
pnpm dev docs

Then navigating through the first menu on http://localhost:8095/en/components/menus/ with the keyboard.

@alexzhang1030
Copy link
Member

Related #211, probably serialize/deserialize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers perf Performance issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants