Skip to content

Docs should be clearer about watch option keys not supporting key paths #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DanielAsher opened this issue Aug 28, 2020 · 2 comments
Closed

Comments

@DanielAsher
Copy link

Version
3.0.0-rc.9

Reproduction link
https://jsfiddle.net/oekwvhd4/

Steps to reproduce
Migrate a v2 app to v3 with a component that uses a watch option with a key path.

What is expected?
The docs clearly state that watch options no longer support key expressions.

Clear migration guidance should be given about moving watched keypaths to mounted this.$watch(() => this.key.path, () => doSomething())

What is actually happening?
This is a significant (and silent!) breaking change, but the docs still refer to key expressions.

@NataliaTepluhina
Copy link
Member

@DanielAsher closing this issue as rc.13 supports dot-delimited paths 🎉

vuejs/core@1c9a0b3

@iazz
Copy link

iazz commented Nov 26, 2020

I'm really glad that key paths are now supported in watch options, but that should probably be explicitly mentioned in the docs, as the docs for $watch do mention that they are not, hence the ambiguity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants