migration: Add Global API Treeshaking #144
Conversation
src/guide/migration/treeshaking.md
Outdated
| } | ||
| ``` | ||
|
|
||
| This will tell webpack “Hey, treat this Vue module as an external library and don’t bother bundling it.” |
There was a problem hiding this comment.
| This will tell webpack “Hey, treat this Vue module as an external library and don’t bother bundling it.” | |
| This will tell webpack to treat this Vue module as an external library. As a result, it will not bundle it. |
The dialogue is nice, but it seems like an abstraction rather than a simple statement which could confuse people not as familiar with English.
There was a problem hiding this comment.
Nice catch! At the same time, people not familiar with English might find "it will not bundle it" confusing though (I did during my early days). WDYT if I take your change and modify it a bit into:
This will tell webpack to treat this Vue module as an external library and not bundle it.
| But what if you’ve never had to deal with manual DOM manipulation, nor are you using or testing async components in our app? Or, what if, for whatever reason, you prefer to use the good old `window.setTimeout()` instead? In such a case, the code for `nextTick()` will become dead code – that is, code that’s written but never used. And dead code is hardly a good thing, especially in our client-side context where every kilobyte matters. | ||
|
|
||
| Module bundlers like [webpack](https://webpack.js.org/) support [tree-shaking](https://webpack.js.org/guides/tree-shaking/), which is a fancy term for “dead code elimination.” Unfortunately, due to how the code is written in previous Vue versions, global APIs like `Vue.nextTick()` are not tree-shakeable and will be included in the final bundle regardless of where they are actually used or not. | ||
|
|
There was a problem hiding this comment.
| ## Current Syntax |
| @@ -1,3 +1,160 @@ | |||
| # Global API Treeshaking | |||
|
|
|||
There was a problem hiding this comment.
| ## Previous Syntax |
There was a problem hiding this comment.
Awesome work @phanan! I've added a few minor questions/nitpicks
Co-authored-by: Natalia Tepluhina <tarya.se@gmail.com>
…to migration/treeshaking
There was a problem hiding this comment.
@phanan Other than the small phrasing we talked about, I'm good to go on this too. Thanks for your hard work on this!
|
@phanan thanks for the fixes! Changes look good to me now 👍 |
|
Thanks y'all! |
No description provided.