Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-import suggestions are not provided for package.json "exports" wildcard paths #3618

Closed
delaneyb opened this issue Oct 4, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@delaneyb
Copy link

delaneyb commented Oct 4, 2023

Repro: repro.zip

Screen.Recording.2023-10-04.at.6.28.37.pm.mp4

With microsoft/TypeScript#55815, we see auto-import suggestions for files matched through wildcard paths in "exports" of dependencies' package.json files.

Upon disabling built in typescript server and enabling Volar however so it runs in takeover mode, these import suggestions seem to disappear, regardless of what TypeScript version is in use.

My suspicion is Volar internally is using some slightly different tsconfig settings to those in my tsconfig.json to produce intellisense results. For example, it seems you need to use a tsconfig.json compilerOptions setting such as module: "nodenext" or "node16" in order for package.json "exports" to be parsed and used for auto-import suggestions under standard built in typescript language server.

@so1ve so1ve added enhancement New feature or request upstream bug Something isn't working and removed enhancement New feature or request upstream labels Oct 4, 2023
@KermanX
Copy link
Collaborator

KermanX commented Aug 14, 2024

Closing this issue because it is likely to have been fixed in v2. Feel free to re-open this issue if the problem still happens.

@KermanX KermanX closed this as completed Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants