-
-
Notifications
You must be signed in to change notification settings - Fork 1k
-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree-Shaking does not work when using multiple stores in Nuxt #2738
Comments
Yeah, this shouldn’t be related to pinia itself, rather to the library doing the tree shaking. It could be mixed to how the auto imports are done or could even be a limitation of the lib handling the minification |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Note
I’m not sure if this issue is related to Pinia, Nuxt, Vite or Rollup, but since the problem occurs specifically when using
defineStore
exports, and not with other composables or exports so I’m opening the issue here.Please let me know if I should open it issue on the right repo.
Reproduction
https://stackblitz.com/edit/github-dylldh?file=app.vue
Steps to reproduce the bug
nuxt generate
./output/_nuxt/Dz77aYJ1.js
foofoofoo
Bug Description
When using Pinia in a Nuxt project and creating more than one store, tree-shaking does not work as expected. Here's an example to illustrate the issue:
After running
nuxt generate
, both thefoo
andbar
stores are bundled into the output, even though they are inside a conditional block that should never run.However, if I use only one store within the
if (false)
block, tree-shaking works as expected:In this case, the unused store is successfully tree-shaken and not included in the bundle.
Expected behavior
Tree-shaking should exclude unused stores from the final bundle, even when multiple stores are defined.
Actual behavior
When more than one store is defined, tree-shaking fails to exclude unused stores, resulting in unnecessary code being bundled.
The text was updated successfully, but these errors were encountered: