-
Notifications
You must be signed in to change notification settings - Fork 199
feat: add default height for Repl component #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
But not all apps need put it in whole screen, like Vue docs |
Yes, maybe In my opinion, when using |
For general usage, I think we can pass the
|
This is fine, but it's like having an Input component, which is invisible by default and must be set to a height before it can be used. Will this be a little troublesome? However, there is corresponding sample code in the documentation, so it should be fine. |
Maybe we can add |
Did you mean |
When using the Repl component as a third-party package, it does not have a default
height
, so it will cause nothing to be seen in the left editor:If this is adopted, we also need to update the default style of
sfc-playground
in vue/core. ( related to: vuejs/core#8628 )