-
Notifications
You must be signed in to change notification settings - Fork 200
feat: add error toggle #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR - we just merged a major PR that lands Monaco editor support which seems to have caused some conflict. Would you mind rebasing your PR? |
Oh, sure thing! |
Rebase done. I noticed that the |
I tried it, but not sure if the top-right corner is the right place to put the toggle. It's quite far from the messages themselves so the connection is not obvious. Maybe it should be floating in the bottom-left corner of the editor - so when the user dismisses an error when they don't want it, they can instantly find the toggle to turn it off. |
Motivation
When focused on coding the error message might be an obstacle in the editor.
So maybe it is better to add a control to let the user decide whether to show the message or not.
Changes
codeType
inCodeMirrorEditor
MessageToggle
componentshowMessage
ref and useMessageToggle
inEditorContaner
to controlMessage
renderScreenshots
This PR can possibly solve #64