Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress of Portal? Here are some suggestions. #62

Closed
wspl opened this issue Jun 25, 2019 · 5 comments
Closed

Progress of Portal? Here are some suggestions. #62

wspl opened this issue Jun 25, 2019 · 5 comments

Comments

@wspl
Copy link

wspl commented Jun 25, 2019

In the early Vue 3.0 trailer, adding Portal component to Vue 3.0 was mentioned. But it seems that the corresponding RFC has not yet been created.

I have a project that is highly dependent on the portal component. Although the portal component is implemented by myself, but the functionality is similar to portal-vue. And encountered some similar problems. I don't know where I can share these issues.

  • Breaks provide/inject: Breaks provide/inject LinusBorg/portal-vue#126 . Portal may cause all mechanisms related to parent-child communication to fail. So it is important to allow mutual access between the portal and the portal-target. And the functions related to communication between the parent and child components also need to take these issues into consideration.

  • Vue-devtools support: The actual components that are mounted cannot be displayed in the children scope of portal-target. If there has a redirect or a mirror, it would be great.

Portal is a very useful feature, especially for scenarios like multi-tab code editors. But it requires some underlying compatibility of the framework to work perfectly. I will be very happy to see it become a built-in feature of Vue.

@LinusBorg
Copy link
Member

You're right, Portals aren't mentioned in any RFC yet (unless I missed something), but the are coming. We already have evaluated the possibilities in our prototyping.

The limitations that you mentioned and we currently see in portal-vue are simply due to missing support for portals on the virtual-dom level. Since in 3.0 we will add Portals to the virtualdom re-implementation, those won't be concerns anymore.

@yyx990803 I think we should decribe how the basic implementation is going to work, maybe in #28 ?

@yyx990803
Copy link
Member

yyx990803 commented Jun 25, 2019

@LinusBorg I think Portal should have its own RFC since it would be usable in templates too.

re implementation: it's already working in the prototype.

@LinusBorg
Copy link
Member

FYI: I'm currently writing up the RFC for this.

@dimensi
Copy link

dimensi commented Oct 4, 2019

@LinusBorg any news?

@LinusBorg
Copy link
Member

#112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants