Allow analyzing Vue files in node_modules

[ProTip]

• I have searched through existing issues
• I have read through docs
• I have read FAQ

Info

• Platform: Linux
• Vetur version: 0.16.2
• VS Code version: 1.30.2

Problem

This is more of a feature request. I'm currently working on a Vue/TypeScript project in which we are sharing an shared, uncompiled "source" package between different projects. Currently Vetur appears to avoid analyzing anything in a node_modules path causing the imported type to fall back on the generic shim interface definition.

I have removed node_modules check from here in my extension locally and confirmed the imported type is resolved correctly:

vetur/server/src/modes/script/serviceHost.ts

Line 219 in 73a0854

return path.endsWith('.vue.ts') && !path.includes('node_modules');

I would like to have the option to include packages in node_modules for analysis. For TypeScript's part I simply need to add the package to the includes section of tsconfig.json and it will work. Perhaps the option to trust the TypeScript includes would suffice?

[octref]

For TypeScript's part I simply need to add the package to the includes section of tsconfig.json and it will work.

So you are including node_modules in tsconfig?

Perhaps the option to trust the TypeScript includes would suffice?

I turned off node_modules since this is a major source for perf issues.

If you do include node_modules/<package>/**/*.vue, they should show up here:

vetur/server/src/modes/script/serviceHost.ts

Line 82 in 4f95998

const files = parsedConfig.fileNames;

Then you can stop ignoring these vue files selectively in the service host. Are you interested in doing a PR?

[tiagoroldao]

@octref ran into this issue on 0.24.0

Tracked it here, in the current code:

vetur/server/src/services/typescriptService/util.ts

Lines 8 to 14 in 5f9974f

	/**
	* If the path ends with `.vue.ts`, it's a `.vue` file pre-processed by Vetur
	* to be used in TS Language Service
	*/
	export function isVirtualVueFile(path: string) {
	return path.endsWith('.vue.ts') && !path.includes('node_modules');
	}

Paths are not ignored, added to tsconfig like so:

  "include": [
    "src/**/*.ts",
    "src/**/*.vue",
    "node_modules/ah-common-lib/**/*.ts",
    "node_modules/ah-common-lib/**/*.vue"],
  "exclude": []

And debugging reveals that the typescript never checks for "Foo.vue" and rather attempts all variants (including "Foor.vue.ts"). Adding the files to parsedConfig (through tsConfig changes) makes no difference as it is the vue

Removing the !path.includes('node_modules') check fixes the issue:

• is there a need for the check?
• is this for performance reasons?
  • if so, can potentially pass scriptFileNameSet to vueSys and use it to check for file presence in the included files