Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vetur keeps file lock on asar files #1474

Closed
3 tasks done
Stanzilla opened this issue Oct 22, 2019 · 6 comments · Fixed by #1752
Closed
3 tasks done

Vetur keeps file lock on asar files #1474

Stanzilla opened this issue Oct 22, 2019 · 6 comments · Fixed by #1752

Comments

@Stanzilla
Copy link

  • I have searched through existing issues
  • I have read through docs
  • I have read FAQ

Info

  • Platform: Windows
  • Vetur version: 0.22.5
  • VS Code version: 1.39.2

Problem

image
Sometimes Vetur keeps a file lock on the output dir of my Vue CLI project

Reproducible Case

Hard to reproduce as it happens randomly

@octref
Copy link
Member

octref commented Oct 23, 2019

Not sure what's the issue. If you can find reproducible steps, feel free to reopen.

@niceue
Copy link

niceue commented Oct 31, 2019

+1

image

@octref
Copy link
Member

octref commented Dec 12, 2019

microsoft/vscode#80146

@dbaumer Do you have any guess might be happening? I'm on language server library 5.3.0

@octref octref reopened this Dec 12, 2019
@octref octref changed the title Vetur keeping file locks on Windows Vetur keeps file lock on asar files Dec 12, 2019
@ToMGitHubN
Copy link

I faced the same problem.

problem:

I am developing an electron app. This plugin locks the asar file and prevents electron from building.

reason:

The vs code was created with electron and has been modified to read asar files for speed.
Some plug-ins may lock asar due to changes in the vs code specification.

I found a useful URL with the extension * .asar.
https://electronjs.org/docs/api/environment-variables#electron_no_asar

Steps to reproduce the problem:

  1. create vue project.
    npx vue create asar-problem

  2. add electron-builder
    cd asar-problem
    npx vue add electron-builder

  3. Open project folder with vs code.And open the vue file with vs code.

  4. electron build
    (There are no asar files at this time. The build was successful.)
    npm run electron:build

  5. electron build
    npm run electron:build

problem!


info:

Platform: Windows
Vetur:0.22.6
VS Code version:1.41.0

Thank you for reading!

@ToMGitHubN
Copy link

@octref Need more information?

@octref
Copy link
Member

octref commented Feb 18, 2020

After adopting V6 node-languageclient this should be fixed. You can track #1719.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants