fix(dev): read file as buffer (#398)

fix #395
vitejs · Jun 18, 2020 · 5ee1d15 · 5ee1d15
1 parent 91f696b
commit 5ee1d15
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/node/server/serverPluginVue.ts b/src/node/server/serverPluginVue.ts
@@ -319,7 +319,7 @@ async function resolveSrcImport(
   const importee = cleanUrl(resolveImport(root, importer, block.src!, resolver))
   const filePath = resolver.requestToFile(importee)
   await cachedRead(ctx, filePath)
-  block.content = ctx.body
+  block.content = (ctx.body as Buffer).toString()
 
   // register HMR import relationship
   debugHmr(`        ${importer} imports ${importee}`)

diff --git a/src/node/utils/fsUtils.ts b/src/node/utils/fsUtils.ts
@@ -12,7 +12,7 @@ const getETag = require('etag')
 interface CacheEntry {
   lastModified: number
   etag: string
-  content: string
+  content: Buffer
 }
 
 const fsReadCache = new LRUCache<string, CacheEntry>({
@@ -26,7 +26,7 @@ const fsReadCache = new LRUCache<string, CacheEntry>({
 export async function cachedRead(
   ctx: Context | null,
   file: string
-): Promise<string> {
+): Promise<Buffer> {
   const lastModified = fs.statSync(file).mtimeMs
   const cached = fsReadCache.get(file)
   if (ctx) {
@@ -51,7 +51,8 @@ export async function cachedRead(
     }
     return cached.content
   }
-  const content = await fs.readFile(file, 'utf-8')
+  // #395 some file is an binary file, eg. font
+  const content = await fs.readFile(file)
   const etag = getETag(content)
   fsReadCache.set(file, {
     content,