fix: defaultRequestToFile should consider optimized modules #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I reproduce this issue in playground and add test in the second commit. |
csr632
force-pushed
the
fix/defaultRequestToFile-optimized-module
branch
from
254bf0f to
3b033ec
Compare
|
We need to run |
|
I'm fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to consider optimized modules in this pr: #230
which leads to a issue when rewriting cross import between optimized modules.
Here is a reproduction:
https://github.com/csr632/test-vite/tree/rewrite-extension-issue
You can also cherry-pick the second commit onto current master branch to see the issue.