Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some package's module entry doesn't have extension #284

Conversation

FallenMax
Copy link

Some popular libs(e.g. rc-tooltip) are setting 'package.json#module' field WITHOUT file extension (.js). For better compatibility, we should add for them?

@yyx990803 yyx990803 closed this in 6269b7f May 28, 2020
@yyx990803
Copy link
Member

Thanks for the PR - but we need to

  1. Only append extension if there isn't one (some packages may use non-js entry)
  2. Also append the extension to the resolved entryPoint, not just the file path.

See 6269b7f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants