Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve browser field in package.json #301

Merged
merged 2 commits into from
May 29, 2020
Merged

fix: resolve browser field in package.json #301

merged 2 commits into from
May 29, 2020

Conversation

csr632
Copy link
Member

@csr632 csr632 commented May 29, 2020

Fix: #294

@yyx990803 yyx990803 merged commit 28d9714 into vitejs:master May 29, 2020
@yyx990803 yyx990803 mentioned this pull request May 29, 2020
Closed
@yyx990803
Copy link
Member

FYI ce3ec6c

@yyx990803
Copy link
Member

Also for the case of styled-components, the only difference between its esm and browser.esm builds is the presence of process.env.NODE_ENV checks, which Vite already handles.

@matheus23 matheus23 mentioned this pull request Jun 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

complex package.json#browser field handling
2 participants
@csr632 @yyx990803