Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import stopped working for some modules #307

Closed
lcmen opened this issue May 29, 2020 · 2 comments
Closed

Import stopped working for some modules #307

lcmen opened this issue May 29, 2020 · 2 comments

Comments

@lcmen
Copy link
Contributor

lcmen commented May 29, 2020

Describe the bug

Importing firebase from npm package does no longer work. This seems like a regression as that import worked fine on 0.17.2 for me.

Reproduction

  1. npm install -S firebase
  2. Add import firebase from 'firebase/app to any JS file.

System Info

  • required vite version: 0.18.1
  • required Operating System: MacOS 10.14.6
  • required Node version: 13.11.0
  • Optional:
    • npm/yarn version: npm 6.13.7
    • Installed vue version (from yarn.lock or package-lock.json): 3.0.0-beta.14
    • Installed @vue/compiler-sfc version: 3.0.0-beta.14

Logs (Optional if provided reproduction)

Console error:

SyntaxError: The requested module '/@modules/@firebase/app/dist/index.cjs.js' does not provide an export named 'default'
@yyx990803
Copy link
Member

firebase/app's browser field points to a cjs file... 🤦

@lcmen
Copy link
Contributor Author

lcmen commented May 30, 2020

Thank you ❤️ ! Works like a charm 🙇 .

@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants