Ensure that the base is used for previous and next links #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElMassimo
commented
Nov 20, 2020
| @@ -35,7 +36,8 @@ export default defineComponent({ | |||
| return { | |||
| hasLinks, | |||
| prev, | |||
| next | |||
| next, | |||
| withBase, | |||
There was a problem hiding this comment.
Another option would be to use withBase in getFlatSidebarLinksFromArray:
if (item.link) {
links.push({ text: item.text, link: withBase(item.link) })
}However, that would also require using withBase in currentPath for the comparison in currentIndex to work as expected.
Calling it in the component seemed consistent with how the logo is currently being rendered.
There was a problem hiding this comment.
Yeah, I would like to refactor the use of withBase, but for now it's being used everywhere so I think this is fine!
kiaking
approved these changes
Nov 20, 2020
| @@ -35,7 +36,8 @@ export default defineComponent({ | |||
| return { | |||
| hasLinks, | |||
| prev, | |||
| next | |||
| next, | |||
| withBase, | |||
There was a problem hiding this comment.
Yeah, I would like to refactor the use of withBase, but for now it's being used everywhere so I think this is fine!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
This pull request fixes next and previous links in sites with a non-default
baseconfiguration.Background 📜
#130 recently moved the previous and next page link calculation to the client side.
Because links used in the sidebar don't include the base, rendering them directly causes them to have an incorrect URL.