Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mixed rgba colors for md code plugins #143

Merged
merged 2 commits into from
Nov 24, 2020
Merged

fix: mixed rgba colors for md code plugins #143

merged 2 commits into from
Nov 24, 2020

Conversation

patak-dev
Copy link
Member

Using rgba(0,0,0,50%) was working in dev but it was converted to an invalid color rgba(0,0%,0%,50%) when building so the highlighted lines were not visible

invalid-color

Switching to a number for alpha (as it is in other rgba values in the css) fixes the issue.

I do not know if rgba(0,0,0,50%) is a valid color to be supported, I looked a bit and this conversion doesn't seem to be the responsibility of vitepress.

@kiaking kiaking added the bug Something isn't working label Nov 24, 2020
@kiaking
Copy link
Member

kiaking commented Nov 24, 2020

@matias-capeletto Thanks a lot! I think merging #142 made conflicts. Could you resolve this one 🙏

@patak-dev
Copy link
Member Author

@kiaking should I do a PR porting the markdown extensions page from vuepress to vitepress docs so we can test these plugins? I think we could directly copy that page into vitepress docs.
https://vuepress.vuejs.org/guide/markdown.html

@kiaking
Copy link
Member

kiaking commented Nov 24, 2020

Oh yeah that would be great idea. Would you like to added it to this PR?

@patak-dev
Copy link
Member Author

Great, I'll look into it. If you do not mind, I prefer to send a new PR for the docs so we can close this one 👍

@kiaking
Copy link
Member

kiaking commented Nov 24, 2020

@matias-capeletto

If you do not mind, I prefer to send a new PR for the docs so we can close this one 👍

Got ya. I'll merge this one for now. Please open another PR for the docs 🙌

@kiaking kiaking merged commit da09266 into vuejs:master Nov 24, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants